Skip to content

[Hub Generated] Review request for Microsoft.DevTestLab to add version stable/2018-09-15#6623

Merged
sarangan12 merged 3 commits intoAzure:masterfrom
joerage:dev-devtestlabs-Microsoft.DevTestLab-2018-09-15
Jul 19, 2019
Merged

[Hub Generated] Review request for Microsoft.DevTestLab to add version stable/2018-09-15#6623
sarangan12 merged 3 commits intoAzure:masterfrom
joerage:dev-devtestlabs-Microsoft.DevTestLab-2018-09-15

Conversation

@joerage
Copy link
Copy Markdown
Contributor

@joerage joerage commented Jul 15, 2019 •
edited
Loading

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

@azuresdkci azuresdkci requested a review from sarangan12 July 15, 2019 21:05
@AutorestCI AutorestCI mentioned this pull request Jul 15, 2019
Merged
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jul 15, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#6414

@azuresdkci
Copy link
Copy Markdown
Contributor

azuresdkci commented Jul 15, 2019

Can one of the admins verify this patch?

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jul 15, 2019 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#5306

@AutorestCI AutorestCI mentioned this pull request Jul 15, 2019
Closed
@AutorestCI AutorestCI mentioned this pull request Jul 15, 2019
Merged
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jul 15, 2019 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3724

@joerage @nschonni
Update specification/devtestlabs/resource-manager/Microsoft.DevTestLa…
c278653 
…b/stable/2018-09-15/DTL.json

Co-Authored-By: Nick Schonning <nschonni@gmail.com>
sarangan12
sarangan12 approved these changes Jul 16, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@sarangan12 sarangan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are simple. Description changes are ok. I am Ok with enum changes also. But removal of a definition, path and changing from required:false definitely needs ARM review and approval. Adding the appropriate label. From SDK side, I do not have any issue. But I am holding off on the merge until ARM team can review.

@sarangan12 sarangan12 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 16, 2019
KrisBash
KrisBash suggested changes Jul 16, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concerns with removal of LIST serviceRunners api

KrisBash
KrisBash approved these changes Jul 17, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signing off with context that removed API path has been removed from service and is not a public opeation

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 17, 2019
@sarangan12 sarangan12 merged commit fcb3fa2 into Azure:master Jul 19, 2019
@AutorestCI AutorestCI mentioned this pull request Jul 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@nschonni nschonni nschonni left review comments

@sarangan12 sarangan12 sarangan12 approved these changes

@KrisBash KrisBash KrisBash approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sarangan12 sarangan12

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@joerage @AutorestCI @azuresdkci @sarangan12 @nschonni @KrisBash